Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebkitRequestFullscreen instead of WebkitRequestFullScreen #1100

Closed
michelt opened this issue Mar 20, 2014 · 4 comments
Closed

WebkitRequestFullscreen instead of WebkitRequestFullScreen #1100

michelt opened this issue Mar 20, 2014 · 4 comments

Comments

@michelt
Copy link
Contributor

michelt commented Mar 20, 2014

In webkit, it's recommended to use webkitRequestFullscreen (with a lower s on screen) instead of webkitRequestFullScreen (uppercase) (new html specifications). It allows to use keaboard events for exemple.

https://dvcs.w3.org/hg/fullscreen/raw-file/tip/Overview.html#dom-element-requestfullscreen

    if (document.mozCancelFullScreen) {
      prefix = 'moz';
      requestFS.isFullScreen = prefix + 'FullScreen';
      requestFS.requestFn = prefix + 'RequestFullScreen';
    } else {
      prefix = 'webkit';
      requestFS.isFullScreen = prefix + 'IsFullScreen';
      requestFS.requestFn = prefix + 'RequestFullscreen';
    }
@mmcc
Copy link
Member

mmcc commented Mar 20, 2014

Interesting...Would you be interested in putting together a pull request to address this?

@michelt
Copy link
Contributor Author

michelt commented Mar 20, 2014

Sure :)

@mmcc
Copy link
Member

mmcc commented Mar 20, 2014

Great. Thanks @michelt!

@heff
Copy link
Member

heff commented May 7, 2014

Closed by #1101

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants