Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dist from gitignore in distribution branch? #1105

Closed
matthewwithanm opened this issue Mar 21, 2014 · 10 comments · Fixed by #1337
Closed

Remove dist from gitignore in distribution branch? #1105

matthewwithanm opened this issue Mar 21, 2014 · 10 comments · Fixed by #1337

Comments

@matthewwithanm
Copy link

I don't think the bower.json and component.json files are very useful since they point to files that aren't actually part of the repo. I can understand the reticence to commit compiled code but AFAIK both bower and component require it. If the project requires a build, it probably shouldn't contain those files.

@matthewwithanm
Copy link
Author

Sorry, I made a mistake here. I see now that the dist directory is committed to the other branch. However, the .gitignore file prevents it from being added to a user's repository. Would it be possible to get that removed from the branch intended for distribution?

I'll change the title of the issue to reflect this. Thanks!

@matthewwithanm matthewwithanm changed the title Remove bower.json or commit dist? Remove dist from gitignore in distribution branch? Mar 21, 2014
@gkatsev
Copy link
Member

gkatsev commented Mar 21, 2014

Does bower actually respect the gitignore? That's lame then.

@matthewwithanm
Copy link
Author

Sorry, bower doesn't respect it. But if a user bower installs the project and then tries to add it to their repo, the dist is ignored (since the .gitignore file is present).

@gkatsev
Copy link
Member

gkatsev commented Mar 21, 2014

Ah, I guess we should make sure that the .gitignore file doesn't get added to the bower install then.

The reason why we have it ignored so that people won't ever make PRs against the concatenated file.

@matthewwithanm
Copy link
Author

Yeah, that makes total sense. Ideally, if the branch is just meant to be used as a package repository for package managers that don't have their own (bower, component), it would only contain the dist files.

@heff heff added the bug label Mar 24, 2014
@heff
Copy link
Member

heff commented Mar 24, 2014

Could we use the ignore feature of the bower.json to ignore the gitignore?

@matthewwithanm
Copy link
Author

Hahaha I think that would work!

@heff
Copy link
Member

heff commented Mar 24, 2014

Nice. Is there a way we can test that without actually publishing a new version?

@matthewwithanm
Copy link
Author

You can bower install git endpoints, and I'm pretty sure you can tack on commit hashes/branches with '#', so you should be able to do bower install https://github.com/videojs/video.js.git#bower-ignore-gitignore.

@mmcc
Copy link
Member

mmcc commented May 16, 2014

No one's had a chance to get to this one yet. Would you be interested in putting together a PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants