-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dist from gitignore in distribution branch? #1105
Comments
Sorry, I made a mistake here. I see now that the dist directory is committed to the other branch. However, the .gitignore file prevents it from being added to a user's repository. Would it be possible to get that removed from the branch intended for distribution? I'll change the title of the issue to reflect this. Thanks! |
Does bower actually respect the gitignore? That's lame then. |
Sorry, bower doesn't respect it. But if a user bower installs the project and then tries to add it to their repo, the dist is ignored (since the .gitignore file is present). |
Ah, I guess we should make sure that the .gitignore file doesn't get added to the bower install then. The reason why we have it ignored so that people won't ever make PRs against the concatenated file. |
Yeah, that makes total sense. Ideally, if the branch is just meant to be used as a package repository for package managers that don't have their own (bower, component), it would only contain the dist files. |
Could we use the ignore feature of the bower.json to ignore the gitignore? |
Hahaha I think that would work! |
Nice. Is there a way we can test that without actually publishing a new version? |
You can bower install git endpoints, and I'm pretty sure you can tack on commit hashes/branches with '#', so you should be able to do |
No one's had a chance to get to this one yet. Would you be interested in putting together a PR? |
I don't think the bower.json and component.json files are very useful since they point to files that aren't actually part of the repo. I can understand the reticence to commit compiled code but AFAIK both bower and component require it. If the project requires a build, it probably shouldn't contain those files.
The text was updated successfully, but these errors were encountered: