-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control bar layout issues when player width is small #1733
Comments
Oh, weird, in that particular case, the 'LIVE' control is still to the right of the duration, though, not visible. It shouldn't be taking up any room at all, if possible, i.e., This also brings about two other issues I've noticed:
|
Agreed on the poster thing, not sure I agree on the I hacked together a super hacky audio-only skin a while back. Might be interesting to revisit the basic concept since there are some issues with just showing the control bar of the default skin. Updating the issue title since technically this would happen even if there was a video playing at low width. |
FWIW, the new base theme layout doesn't have this issue. I'm kicking around the idea of player size, so we can automatically hide elements when a player goes below a certain width. Think similar to media-queries, but we basically have to implement them ourselves since we only care about the width of the player component and not |
This should be fixed in the most recent skin. |
I understand that support for the tag is not complete (#537), but just wanted to flag that the control bar does not layout correctly (I'm using Chrome Version 39.0.2171.71 on Win 7) when playing audio. Specifically, the Mute button gets dropped below the control bar unless the width is specified; see this from @tim-peterson's demo at http://tim-peterson.github.io/videojs-playlist/.
Also, if the "poster" is not present in the HTML, it seems like the window size should just be the controlbar size, and the Fullscreen button should be omitted.
The text was updated successfully, but these errors were encountered: