Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If cover art becomes scaled the borders around it are transparent meaning video can be seen below #1869

Closed
tjenkinson opened this issue Feb 16, 2015 · 2 comments

Comments

@tjenkinson
Copy link
Contributor

Just found a minor issue that is when you have a cover art image that doesn't fit the player and it is scaled down, the player element is visible outside the scaled image.

This tweak sets the background-color property which means the player will always be completely covered if the poster does not fit exactly, or if the poster image cannot be loaded for some reason/whilst it's loading.

Here is what happens currently:
image

And here is what it looks like with the background-color property applied:
image

I have submitted a pull request at: #1868

@heff heff added the bug label Feb 25, 2015
@gkatsev
Copy link
Member

gkatsev commented Nov 10, 2015

Looking at the sass code for the new skin, seems like it may have regressed.

@gkatsev
Copy link
Member

gkatsev commented Apr 19, 2016

Fixed by #3267.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants