Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video.js captions (not native browser captions) are broken in V5 #2172

Closed
OwenEdwards opened this issue May 19, 2015 · 6 comments
Closed

video.js captions (not native browser captions) are broken in V5 #2172

OwenEdwards opened this issue May 19, 2015 · 6 comments
Milestone

Comments

@OwenEdwards
Copy link
Member

In the sample docs/examples/simple-embed/index.html, when non-native captions are used (I'm using Firefox 37 on Windows 7), the captions menu includes the captions setting option. Selecting the english option does not display the captions.

I get a 'downloadable font rejected by sanitizer ... /build/temp/font/VideoJS.eot' error in the console.

@OwenEdwards
Copy link
Member Author

The 'downloadable font rejected by sanitizer..." error was a red herring!

With further experimentation, a way to get captions displayed is to use the captions settings to change the font color; if this is done while a caption should be displayed, then the caption appears, otherwise the existing caption is cleared. If you change the color while no caption should be displayed, then nothing happens, and the upcoming captions aren't displayed.

I'm guessing this is due to caption events not getting fired by VideoJS, but that changing the captions settings somehow fires an event which may display the current caption? I'm hoping this gets fixed before V5 is released! @gkatsev, have you taken a look at this?

@heff
Copy link
Member

heff commented May 29, 2015

Wow, that's amazing you found that! Yeah, this will have to be fixed for 5.0.

@heff heff added this to the v5.0.0 milestone May 29, 2015
@OwenEdwards OwenEdwards changed the title video.js captions (not native browser captions) are broken in V5 (specifically v5.0.0-16) video.js captions (not native browser captions) are broken in V5 May 29, 2015
@psharmz
Copy link

psharmz commented May 29, 2015

this also occurs in chrome and safari with flash only and flash first tech orders. Should that be noted as a separate issue?

@gkatsev
Copy link
Member

gkatsev commented May 29, 2015

Flash and non-native vtt support is when the emulated captions should come up.
I'll take a look soon.

@heff
Copy link
Member

heff commented Jul 8, 2015

#2215 should fixe this. Someone want to confirm?

@OwenEdwards
Copy link
Member Author

Confirmed; this is fixed in v5.0.0-rc.6.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants