Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen triggers full window on iPad #2350

Closed
dmlap opened this issue Jul 13, 2015 · 3 comments
Closed

Fullscreen triggers full window on iPad #2350

dmlap opened this issue Jul 13, 2015 · 3 comments
Assignees
Milestone

Comments

@dmlap
Copy link
Member

dmlap commented Jul 13, 2015

Tested on an iPad Mini, iOS 8.3

Steps to Reproduce

  1. Open the sandbox and play the video
  2. Tap the fullscreen button
  3. Tap the native fullscreen button to exit fullscreen

Expected: the player returns to its size before fullscreen
Actual: the player fills the entire sandbox window

@dmlap dmlap added this to the v5.0.0 milestone Jul 13, 2015
@gkatsev
Copy link
Member

gkatsev commented Jul 14, 2015

sounds like this is the cause of #2276

@gkatsev gkatsev self-assigned this Jul 14, 2015
@gkatsev
Copy link
Member

gkatsev commented Jul 15, 2015

14:45:07 < gkatsev> I know why on ios the player is in "fullwindow" mode after exiting the fullscreen
14:45:37 < gkatsev> whether the player is fullscreen or not is set up on the player currently
14:45:49 < gkatsev> but on ios, which *still* uses the old way of doing stuff
14:45:57 < gkatsev> is inside the html5 tech
14:46:17 < gkatsev> and can't set whether the player is fullscreen yet
14:46:30 < gkatsev> so, our fullscreen handler never removes the vjs-fullscreen class

@gkatsev
Copy link
Member

gkatsev commented Jul 16, 2015

Weird, this didn't auto-close. Maybe because of how we merged the PR in. Anyway, fixed by #2357.

@gkatsev gkatsev closed this as completed Jul 16, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants