Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there functional tests for mobile platforms? #2529

Closed
jimkang opened this issue Aug 31, 2015 · 7 comments
Closed

Are there functional tests for mobile platforms? #2529

jimkang opened this issue Aug 31, 2015 · 7 comments

Comments

@jimkang
Copy link

jimkang commented Aug 31, 2015

Hey, apologies if I missed it, but I just reading contributing.md, cloned and ran the tests. I noticed the config in the Gruntfile seems to indicate these are the covered platforms:

      // these are run locally on local browsers
      dev: { browsers: ['Chrome', 'Firefox', 'Safari'] },
      chromecanary: { browsers: ['ChromeCanary'] },
      chrome:       { browsers: ['Chrome'] },
      firefox:      { browsers: ['Firefox'] },
      safari:       { browsers: ['Safari'] },
      ie:           { browsers: ['IE'] },
      phantomjs:    { browsers: ['PhantomJS'] },

      // this only runs on PRs from the mainrepo on BrowserStack
      browserstack: { browsers: ['chrome_bs'] },
      chrome_bs:    { browsers: ['chrome_bs'] },
      firefox_bs:   { browsers: ['firefox_bs'] },
      safari_bs:    { browsers: ['safari_bs'] },
      ie11_bs:      { browsers: ['ie11_bs'] },
      ie10_bs:      { browsers: ['ie10_bs'] },
      ie9_bs:       { browsers: ['ie9_bs'] },
      ie8_bs:       { browsers: ['ie8_bs'] }

Now that you have BrowserStack, are there plans to cover Mobile Safari and the Android browsers? Or have you already somewhere else?

@heff
Copy link
Member

heff commented Aug 31, 2015

Mobile platforms are still being tested manually because we've found them to be too inconsistent on Sauce/Browserstack. @forbesjo anything to add here?

@jimkang
Copy link
Author

jimkang commented Sep 1, 2015

Ah, understood. Is there a list of either officially supported mobile browsers or a list of mobile browsers on which video.js is generally known to work?

@gkatsev
Copy link
Member

gkatsev commented Sep 1, 2015

Latest iOS and latest Chrome for Android should generally work. The Native Android Browser is having issues. In the master branch (5.0) we disabled our custom controls and it works mostly fine there too now.

@forbesjo
Copy link
Contributor

forbesjo commented Sep 1, 2015

I'll test out iOS and Android on BrowserStack and open a PR if it looks good. I think the tests were flaky on Sauce Labs which is why they were removed?

@moay
Copy link

moay commented Sep 1, 2015

Firefox on android seems to have major problems with VJS5. It works with vjs-youtube (more or less), but with local files it is not working for me. Maybe my fault, but there is one warning in the console:

mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create

Has anyone got it working with firefox mobile on android?

@jimkang
Copy link
Author

jimkang commented Sep 1, 2015

@gkatsev Thanks. We'll look out for issues on Android Chrome and Mobile Safari, but assume they're likely to be OK. Anyone have any experiences with the Android 4.0 default browser?

@gkatsev
Copy link
Member

gkatsev commented Jan 9, 2017

I don't think we're going to change our matrix right now but I put a task for myself to try it out again.

@gkatsev gkatsev closed this as completed Jan 9, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants