-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.0.0-rc.90 : Bower SCSS problem #2611
Comments
We're still trying to figure out the best way to handle the sass files and understand how they'll be used. What specifically were hoping to use the sass files to do? |
hey @heff, Mostly, i'm importing plugin scss files with sass import function (you can see example code below). After that, i'm importing this file to my general scss file. For information, i just import one time. Example code:
Only problem in this scenario is font files of videojs. If work on the different folders and when you send files to production you do compile or something, you cannot use the font files directly so maybe you can create another repo for that (with bower support). When i work with gulp or grunt, i always copy necessary files to production side with copy function of them. |
@mmcc any new thoughts on this? |
This scenario is why I was leaning towards the idea of outputting the compiled css as just an SCSS file for scenarios like this. The problem is we're basically doing the same thing, but we're expecting to be able to pull from |
Shouldn't the |
It probably should, since that's what we're doing the styles property of the package.json. |
+1 |
1+ |
No need to continue the +1s, this is confirmed. |
Going to also note that this really breaks with npm 3.x because it installs dependencies as siblings instead of as nested To reproduce, make sure you have npm 3 running and: npm install video.js
node-sass node_modules/video.js/src/css/video-js.scss Should yield:
|
Hey,
In video-js.scss file, It's trying to import "../../node_modules/videojs-font/scss/icons" file but it doesn't create node_modules folder in Bower. When you try to import videojs.scss file to another scss, it doesnt work.
The text was updated successfully, but these errors were encountered: