-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Audio/Video Track support to video.js #3137
Comments
It's interesting that in the DOM, AudioTrackList, VideoTrackList, and TextTrackList all extend from EventTarget directly instead of from a "TrackList" parent. |
Oh, just realized that you mentioned that we can pull TextTrack out into a shared Track. We probably should do that separately from the TextTrackList PR to make it easier to merge. We should try and make each PR for this epic as small and self contained as possible so we could merge chunks one at a time and not fall into the trap we always do (like captions) where we have a massive PR out for 3 months before it gets merged. |
One other thing to mention, each of these tests need accompanying tests, of course :) |
Updated the issues steps to separate TextTrack and TextTrackList into their own steps (for moving common functionality out of them) |
added another task to move all of the tracks/text-track* files into tracks/text/text-track* |
added another task to convert remaining text-track unit test into full es6 syntax |
#3173 is now merged, I think this issue can be closed |
Purpose
To extend the capabilities of video.js so that we can support multiple audio and video tracks much like we support multiple text tracks right now.
Proposal
API Spec
The main portions of the API will be defined in accordance with embedded content specification
Integration with video.js with follow the current patterns that TextTrack has laid out where it makes sense.
Acceptance Criteria Most Covered by #3173
moveNot Doingtracks/text-track*
files intotracks/text/text-track*
- (Moved Text Track files and Unit tests into a text sub directory #3146)Research and implement the HTMLSourceElement api if requiredNot DoingThe text was updated successfully, but these errors were encountered: