We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logByType
I've only noticed this in IE10 (works fine in IE9 and IE11). In the function logByType (in log.js src file), the following error is thrown:
log.js
SCRIPT65535: Invalid calling object
If you simply surround the fn(args.map.... call in a try/catch, it solves the issue. However, I don't know if this is the best solution.
fn(args.map....
Explain in detail the exact steps necessary to reproduce the issue.
No exception to be thrown and VideoJS initialize normally.
Exception thrown
Current master branch
master
IE10
Windows *
VAST/VPAID plugin
The text was updated successfully, but these errors were encountered:
Confirmed this and will fix - thanks for catching it @alex-phillips
Sorry, something went wrong.
@misteroneill I can quick submit a PR for the try/catch solution if that is preferable to get it merged in faster. Just let me know. Thanks!
@alex-phillips Thanks, but I think I've got something. Will have a PR shortly. 😄
Should be fixed in 5.11.0.
misteroneill
Successfully merging a pull request may close this issue.
Description
I've only noticed this in IE10 (works fine in IE9 and IE11). In the function
logByType
(inlog.js
src file), the following error is thrown:If you simply surround the
fn(args.map....
call in a try/catch, it solves the issue. However, I don't know if this is the best solution.Steps to reproduce
Explain in detail the exact steps necessary to reproduce the issue.
Results
Expected
No exception to be thrown and VideoJS initialize normally.
Actual
Exception thrown
Error output
Additional Information
versions
videojs
Current
master
branchbrowsers
IE10
OSes
Windows *
plugins
VAST/VPAID plugin
The text was updated successfully, but these errors were encountered: