Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove un-needed contructor and function overrides #3721

Merged
merged 1 commit into from
Nov 4, 2016
Merged

remove un-needed contructor and function overrides #3721

merged 1 commit into from
Nov 4, 2016

Conversation

brandonocasey
Copy link
Contributor

@brandonocasey brandonocasey commented Oct 26, 2016 •
edited
Loading

Description

  • Removes un-needed constructor overrides from button and big-play-button
  • Removes un-needed addChild override from clickable-component
  • Created an issue for the TODO comment that was removed

Requirements Checklist

  • Feature implemented / Bug fixed
  • Reviewed by Two Core Contributors

misteroneill
misteroneill approved these changes Oct 26, 2016
View reviewed changes
Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandonocasey brandonocasey mentioned this pull request Oct 27, 2016
Merged
2 tasks
@gkatsev gkatsev added this to the 5.13 milestone Nov 4, 2016
@gkatsev gkatsev merged commit 6889e92 into videojs:master Nov 4, 2016
@brandonocasey brandonocasey deleted the chore/remove-unnecessary-overrides branch December 6, 2016 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misteroneill misteroneill misteroneill approved these changes

Assignees
No one assigned
Labels
confirmed
Projects
None yet
Milestone
5.13
Development

Successfully merging this pull request may close these issues.
3 participants
@brandonocasey @misteroneill @gkatsev