-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iPhone displays double controls #3762
Comments
@marinaglancy I think so but to confirm, this is also resolved by using |
Double controls do not appear on ios 10 when using playsinline attribute, but since it's not a default attribute (and actually an optional one), I believe, videojs should address this in the player. Double controls can't be hidden on ios 9 at all. On previous versions of ios, if I remember correctly, only native controls are displayed. |
+1 |
I also see the issue of double controls in iPhone6s plus with ios 10.2. FYI, I use video::-webkit-media-controls-panel-container {
display: none !important;
} to hide it. it works. |
@Pleasurazy It has no effect here on an iPhone 7 :/
seams to work. |
Does anyone perhaps have a working code example for me on how to play video inline on iOS? We have read extensively in the forums and tried all suggestions but we just can't seem to get it to work |
none of the above solutions worked for me. still seeing video.js and native browser controls on IOS 13 |
@verybluebot can you provide more details? I don't actually see double controls anymore and haven't for a while. |
I had to use @marinaglancy 's solution with the css and also the I am currently using videojs inside a react app, so I have this scenario:
But to really make it work, I had to use the Trying on Safari / iPhone 8 / iOS 13.6 |
@gkatsev Im using a IOS
adding the boolean property |
The only way I could get this to work was by specifying |
Is there a solution for this? I do not want to use playsinline, same as @arcticmatt |
Same as @arcticmatt and @simplexx . The very reason our team came to this thread is because we don't want |
As far as I know, there are only two solutions currently to fix this problem, both are not elegant. First one is playsinline, as discussed already. Second one is to detect the browser via javascript and if it is mobile safari, implement some logic to hide the videojs controls and only use the native controls. Apart from that, there is no solution currently (please correct me if I am wrong). If somebody has some code for solution 2. - Would be nice to have it here as a reference. |
Also confirming that Solution 2 would solve the duplicate controls, but it does not achieve what we want. We want to only display the videojs controls. Hide the native controls at all times except in full screen.
If you don't want to use |
@storyguy88 The only additional solution I can think of is to change the approach to using playsinline, and then making the video parent container fullscreen on video play. This way, videojs could be used in pseudo-fullscreen, all without native controls. Did not try this yet though, but I am pretty sure it's possible. |
Option 2 is the I've not been able before, but testing now I can reproduce this consitently if swiping down to exit, but still not using the close button. It's a Safari bug that's adding the native controls unasked for, but disabling controls on the video el on exiting fullscreen will work around it. |
@mister-ben I'm hoping my research documented below confirms your approach. The following can be summarized as the following: On iOS:
If Looking for a solution to override and force the Screenshots |
Thanks for the detail!. That matches what I'm seeing. Could you try out this and see if that's fixing it for you? It does on Simulator and the one iPhone I have to hand. https://deploy-preview-7634--videojs-preview.netlify.app/sandbox/index.html |
Confirmed @mister-ben ! On my iphone, whatever is happening in that sandbox is exactly as expected. Video plays full screen (no |
Hey @mister-ben , great work on #7634 ! Is that merge-able? We're excited to use it. |
I decided to separate this problem from #3761 because I can suggest a patch for this one.
Problem: Videos on iPhone have double controls - one native and one provided by Video.JS.
There is no difference if I set
"nativeControlsForTouch": false
or not (as suggested in #3305).Specifying a poster on the video hides the play button but still does not hide the controls when you click the video in non-fullscreen mode. I suggest you to add this to standard Video.JS CSS something like that:
Example: http://prototype.moodle.net/media/videojs1.htm (without custom CSS)
http://prototype.moodle.net/media/videojs2.htm (with custom CSS)
I have created an issue in Moodle tracker https://tracker.moodle.org/browse/MDL-56829 too
The text was updated successfully, but these errors were encountered: