-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: resets pastSeekEnd_ variable. #6249
feat: resets pastSeekEnd_ variable. #6249
Conversation
Isn't it possible that we've just fallen behind so much? |
Hi Gary, Yes, I think so, |
It definitely makes sense for that example but is it possible that we've actually fallen behind enough to be more than 1.5x the seekable increment? |
Hi Gary, I think it may be possible when somebody has a segment duration set much higher than 12. The video.js has a seeking increment by default set to 12. So I guess if somebody will increase segment duration value in the manifest to be a little higher than 1.5 x 12 = 18 then it is possible but only when somebody stops ingestion and reload the player. However, I don't think that someone will really set a segment duration higher than 12 in the manifest... Maybe this segment increment default value should be configurable somehow. |
Looks like tests are failing: https://travis-ci.org/videojs/video.js/builds/592287905#L777-L818. Can you take a look? |
Yes, of course. I have just updated the tests... should work now. |
Description
It resets pastSeekEnd_ value to 0 when its value is higher than seeking increment value.
In rare cases, for example when we stop ingesting the live stream. The playlist duration doesn't change at all but we are constantly increasing the value of the pastSeekEnd_ variable which forces the DVR progress forward and increases the size of the gap on the progress bar.
Specific Changes proposed
If the pastSeekEnd_ value is higher than 1.5 x seeking increment value then set pastSeekEnd_ variable value to 0.
Requirements Checklist