Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resets pastSeekEnd_ variable. #6249

Merged
merged 2 commits into from
Nov 15, 2019

Conversation

gjanblaszczyk
Copy link
Member

Description

It resets pastSeekEnd_ value to 0 when its value is higher than seeking increment value.
In rare cases, for example when we stop ingesting the live stream. The playlist duration doesn't change at all but we are constantly increasing the value of the pastSeekEnd_ variable which forces the DVR progress forward and increases the size of the gap on the progress bar.

Specific Changes proposed

If the pastSeekEnd_ value is higher than 1.5 x seeking increment value then set pastSeekEnd_ variable value to 0.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@gkatsev
Copy link
Member

gkatsev commented Oct 2, 2019

Isn't it possible that we've just fallen behind so much?

@gjanblaszczyk
Copy link
Member Author

Hi Gary, Yes, I think so,
you can see the problem here: https://codepen.io/grbla/pen/zYYOqqM
Please play the stream and wait around 40 sec. You will see that the progress bar is increasing the duration value forever but in fact, it should stay inside the live edge bounds and duration should never fallback behind the liveEdgeWindow value.

@gkatsev
Copy link
Member

gkatsev commented Oct 3, 2019

It definitely makes sense for that example but is it possible that we've actually fallen behind enough to be more than 1.5x the seekable increment?

@gjanblaszczyk
Copy link
Member Author

Hi Gary, I think it may be possible when somebody has a segment duration set much higher than 12. The video.js has a seeking increment by default set to 12. So I guess if somebody will increase segment duration value in the manifest to be a little higher than 1.5 x 12 = 18 then it is possible but only when somebody stops ingestion and reload the player. However, I don't think that someone will really set a segment duration higher than 12 in the manifest... Maybe this segment increment default value should be configurable somehow.

@gkatsev
Copy link
Member

gkatsev commented Oct 7, 2019

Looks like tests are failing: https://travis-ci.org/videojs/video.js/builds/592287905#L777-L818. Can you take a look?

@gjanblaszczyk
Copy link
Member Author

Yes, of course. I have just updated the tests... should work now.

@gkatsev gkatsev added the needs: LGTM Needs one or more additional approvals label Nov 12, 2019
@gkatsev gkatsev merged commit ccca846 into videojs:master Nov 15, 2019
@gkatsev gkatsev removed the needs: LGTM Needs one or more additional approvals label Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants