fix: bring back Android 4.x support #6289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we are running on a browser that doesn't support WeakMap, use a simple WeakMap sham as a fallback.
gkatsev
changed the title
yanyunlong
reviewed
Oct 30, 2019
misteroneill
approved these changes
Nov 4, 2019
gkatsev
added a commit
that referenced
this pull request
Nov 7, 2019
Use a WeakMap and Set shams for browsers that don't support it.
This was referenced Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are running on a browser that doesn't support WeakMap, use a
simple WeakMap sham as a fallback.
Also, add a tiny Set sham.
We received a request (in #6103) that we broke Android 4.x due to lack to WeakMap. This creates a WeakMap sham to use as a fallback when WeakMap isn't available.
To test locally, I change the file to always create the FakeWeakMap and use that as the default export.