fix: slider screenreader value returning as NaN #6404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
commented
Jan 14, 2020
| @@ -268,7 +268,7 @@ class Slider extends Component { | |||
| * percentage filled that the slider is | |||
| */ | |||
| getProgress() { | |||
| return clamp(this.getPercent(), 0, 1).toFixed(4); | |||
| return Number(clamp(this.getPercent(), 0, 1).toFixed(4)); | |||
There was a problem hiding this comment.
toFixed turns the number that we get back from clamp into a string so 0 becomes "0.0000" and 0.8777657 becomes "0.8777" when it should be a number still.
brandonocasey
commented
Jan 14, 2020
| @@ -244,7 +244,7 @@ class Slider extends Component { | |||
| const progress = this.getProgress(); | |||
|
|
|||
| if (progress === this.progress_) { | |||
| return; | |||
| return progress; | |||
There was a problem hiding this comment.
This function has a return value of progress so early returns should return that. This prevents child classes that call this method from setting progress to undefined when progress has not changed.
|
This likely fixes #5984. Wonder if @misteroneill remembers any specific cases we should look out for. |
gkatsev
approved these changes
Jan 15, 2020
This was referenced Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Without these changes
area-valuenowfor the seek bar often reportsNaN