Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use click event for tech click event #7302

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

Chocobozzz
Copy link
Contributor

Description

Use click instead of mouseup to handle tech click events. Closes #7291

Specific Changes proposed

Replaced mouseup event by click.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

Flash is not really a thing anymore.
Prevent some weird behaviour when pressing left click outside the player, move the custor inside the player and release the button
@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #7302 (632187b) into main (a8a5e02) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7302      +/-   ##
==========================================
+ Coverage   79.45%   79.47%   +0.02%     
==========================================
  Files         115      115              
  Lines        7266     7264       -2     
  Branches     1746     1745       -1     
==========================================
  Hits         5773     5773              
+ Misses       1493     1491       -2     
Impacted Files Coverage Δ
src/js/player.js 86.63% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8a5e02...632187b. Read the comment docs.

@Chocobozzz Chocobozzz changed the title Feature/click event Use click event for tech click event Jul 2, 2021
@gkatsev gkatsev merged commit 956379c into videojs:main Jul 27, 2021
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Flash is not really a thing anymore.
Prevent some weird behaviour when pressing left click outside the player, move the custor inside the player and release the button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use 'click' insteadof 'mouseup' event to trigger tech click
3 participants