docs(react): update react functional component tutorial #7377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #7377 +/- ##
=======================================
Coverage 79.72% 79.72%
=======================================
Files 116 116
Lines 7295 7296 +1
Branches 1753 1754 +1
=======================================
+ Hits 5816 5817 +1
Misses 1479 1479
Continue to review full report at Codecov.
|
gkatsev
reviewed
Aug 19, 2021
docs/guides/react.md
Outdated
| </div> | ||
| ); | ||
| React.useEffect(() => { | ||
| // make sure VjsPlayer only initial once |
There was a problem hiding this comment.
nit:
Suggested change
| // make sure VjsPlayer only initial once | |
| // make sure Video.js player is only initialized once |
Comment on lines
+29
to
+32
| // you can update player here [update player through props] | ||
| // const player = playerRef.current; | ||
| // player.autoplay(options.autoplay); | ||
| // player.src(options.sources); |
docs/guides/react.md
Outdated
| } | ||
| }, [options]); | ||
|
|
||
| // Dispose VjsPlayer when functional component actually unmount |
There was a problem hiding this comment.
nit:
Suggested change
| // Dispose VjsPlayer when functional component actually unmount | |
| // Dispose the Video.js player when the functional component unmounts |
docs/guides/react.md
Outdated
| const handlePlayerReady = (player) => { | ||
| playerRef.current = player; | ||
|
|
||
| // you can handle player's events here |
There was a problem hiding this comment.
nit:
Suggested change
| // you can handle player's events here | |
| // you can handle player events here |
docs/guides/react.md
Outdated
| }; | ||
|
|
||
| // const changePlayerOptions = () => { | ||
| // // you can update player through VjsPlayer instance |
There was a problem hiding this comment.
nit:
Suggested change
| // // you can update player through VjsPlayer instance | |
| // // you can update the player through the Video.js player instance |
| <VideoJS options={videoJsOptions}/> | ||
|
|
||
|
|
||
| <VideoJS options={videoJsOptions} onReady={handlePlayerReady} /> |
brandonocasey
approved these changes
Aug 23, 2021
|
Thanks! |
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#7361
Specific Changes proposed
Please list the specific changes involved in this pull request.
Requirements Checklist