Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Traditional Chinese (Taiwan) translation #7483

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

toto6038
Copy link
Contributor

@toto6038 toto6038 commented Oct 27, 2021

Description

Improvement of zh-TW translation quality. One of the problems is the original translation inappropriately used words of Simplified Chinese (China) terminology rather than of Traditional Chinese (Taiwan).
Changes of term are made by referencing Microsoft Language Portal and Mozilla Firefox, which I regard as reliable, authoritative sources.

Specific Changes proposed

Fixed weird translation of strings related to "seek to live" and 'font', and weird usage of terms 'video' and 'audio'. Some refinement is made to improve existing translation as well.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

Fixed weird translation of  strings related to "seek to live" and 'font', and weird usage of terms 'video' and 'audio'. Some refinement is made to improve existing translation as well.
@welcome
Copy link

welcome bot commented Oct 27, 2021

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@gkatsev gkatsev added the needs: LGTM Needs one or more additional approvals label Nov 10, 2021
@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #7483 (ef55d65) into main (4d1fb4a) will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7483      +/-   ##
==========================================
+ Coverage   79.72%   79.96%   +0.23%     
==========================================
  Files         116      116              
  Lines        7296     7296              
  Branches     1754     1754              
==========================================
+ Hits         5817     5834      +17     
+ Misses       1479     1462      -17     
Impacted Files Coverage Δ
src/js/utils/browser.js 54.32% <0.00%> (ø)
src/js/player.js 87.64% <0.00%> (+0.40%) ⬆️
src/js/tech/tech.js 83.38% <0.00%> (+0.59%) ⬆️
src/js/tech/html5.js 64.92% <0.00%> (+1.30%) ⬆️
...rc/js/control-bar/progress-control/time-tooltip.js 84.61% <0.00%> (+2.56%) ⬆️
src/js/control-bar/picture-in-picture-toggle.js 81.81% <0.00%> (+4.54%) ⬆️
src/js/control-bar/control-bar.js 100.00% <0.00%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d1fb4a...ef55d65. Read the comment docs.

@gkatsev gkatsev merged commit 11228cf into videojs:main Nov 10, 2021
@welcome
Copy link

welcome bot commented Nov 10, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@misteroneill misteroneill removed the needs: LGTM Needs one or more additional approvals label Nov 10, 2021
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Fixed weird translation of  strings related to "seek to live" and 'font', and weird usage of terms 'video' and 'audio'. Some refinement is made to improve existing translation as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants