Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a comment of the player's event #7506

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Conversation

iChengbo
Copy link
Contributor

@iChengbo iChengbo commented Nov 10, 2021

Description

Please describe the change as necessary.
If it's a feature or enhancement please be as detailed as possible.
If it's a bug fix, please link the issue that it fixes or describe the bug in as much detail.

  • fix a comment of the player's event

Specific Changes proposed

Please list the specific changes involved in this pull request.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #7506 (a74848f) into main (8e8b7be) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7506   +/-   ##
=======================================
  Coverage   79.73%   79.73%           
=======================================
  Files         116      116           
  Lines        7299     7299           
  Branches     1755     1755           
=======================================
  Hits         5820     5820           
  Misses       1479     1479           
Impacted Files Coverage Δ
src/js/player.js 87.24% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e8b7be...a74848f. Read the comment docs.

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@gkatsev gkatsev added the needs: LGTM Needs one or more additional approvals label Nov 10, 2021
@misteroneill misteroneill removed the needs: LGTM Needs one or more additional approvals label Nov 10, 2021
@gkatsev gkatsev merged commit ca2f5a3 into videojs:main Nov 10, 2021
@iChengbo iChengbo deleted the fix/comments branch November 10, 2021 23:45
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants