Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add some FAQ entries #7609

Merged
merged 5 commits into from
Feb 8, 2022
Merged

Conversation

mister-ben
Copy link
Contributor

Minor doc additions for things commonly encountered in Slack/SO etc

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #7609 (40b7590) into main (eeda26f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7609   +/-   ##
=======================================
  Coverage   80.24%   80.24%           
=======================================
  Files         116      116           
  Lines        7325     7325           
  Branches     1771     1771           
=======================================
  Hits         5878     5878           
  Misses       1447     1447           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeda26f...40b7590. Read the comment docs.

Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Ben! I made some suggestions to maintain American-style spellings for consistency. Also, found a few typos!

docs/guides/faq.md Outdated Show resolved Hide resolved
docs/guides/faq.md Outdated Show resolved Hide resolved
docs/guides/troubleshooting.md Outdated Show resolved Hide resolved
docs/guides/troubleshooting.md Outdated Show resolved Hide resolved
docs/guides/troubleshooting.md Outdated Show resolved Hide resolved
Co-authored-by: Pat O'Neill <pgoneill@gmail.com>
Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

Thanks, Ben

@misteroneill misteroneill merged commit 53cbfc6 into videojs:main Feb 8, 2022
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Co-authored-by: Pat O'Neill <pgoneill@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants