fix: Fix playback rate iteration if rates are not in the ascending order

[BruceRodrigues]

On the playback rate button's click, the iteration over all possible rates will not happen as expected. E.g. if you follow youtube's pattern ([ 2, 1.75, 1.5, 1.25, 1, 0.75, 0.5, 0.25 ]), and click on the playback rate button it will change to 2x and you won't be able to change it anymore.

Description

Fixes #7617

Specific Changes proposed

The iteration over the rates array are now done by the array's index.

Requirements Checklist

• Feature implemented / Bug fixed
• If necessary, more likely in a feature request than a bug fix
  • Change has been verified in an actual browser (Chrome, Firefox, IE)
  • Unit Tests updated or fixed
  • Docs/guides updated
  • Example created (starter template on JSBin)
• Reviewed by Two Core Contributors

[welcome]

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

• Run npm run lint -- --errors locally to catch formatting errors earlier.
• Include tests when adding/changing behavior.
• Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

[mister-ben]

Thanks. This makes sense, but it would be good to add a test.

[BruceRodrigues]

Thanks. This makes sense, but it would be good to add a test.

Sure thing! I'll do that!

[misteroneill]

Nice, thanks for the PR. Would you mind adding some tests to verify? Nevermind, saw above comment after submitting.

[BruceRodrigues]

Nice, thanks for the PR. Would you mind adding some tests to verify? Nevermind, saw above comment after submitting.

Hey guys! Sorry for the late reply. Just added some tests to check the playback rate iteration.

[codecov]

Codecov Report

Merging #7618 (c16a39a) into main (53cbfc6) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #7618      +/-   ##
==========================================
+ Coverage   80.24%   80.36%   +0.11%     
==========================================
  Files         116      116              
  Lines        7325     7322       -3     
  Branches     1771     1770       -1     
==========================================
+ Hits         5878     5884       +6     
+ Misses       1447     1438       -9     

Impacted Files	Coverage Δ
...ar/playback-rate-menu/playback-rate-menu-button.js	96.29% <100.00%> (+15.59%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53cbfc6...c16a39a. Read the comment docs.

[misteroneill]

Seems solid and I tested it manually and works as advertised! 👍

[gkatsev]

Thanks!

[welcome]

Congrats on merging your first pull request! 🎉🎉🎉