Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(text-track-controls): fix failing test caused by incompatibility between PRs #7686

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

misteroneill
Copy link
Member

Description

An incompatibility was introduced between a test written for #7604 and the changes introduced in #7633 - this addresses it to unblock release of 7.19.

Specific Changes proposed

Since text tracks no longer rely on the timeupdate event (though they still have a timeupdateHandler method), triggering the chapter menu item update on timeupdate simply did not work. Calling timeupdateHandler() manually does.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #7686 (d58e80f) into main (28bdc7d) will increase coverage by 0.07%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main    #7686      +/-   ##
==========================================
+ Coverage   80.83%   80.91%   +0.07%     
==========================================
  Files         116      116              
  Lines        7451     7455       +4     
  Branches     1805     1806       +1     
==========================================
+ Hits         6023     6032       +9     
+ Misses       1428     1423       -5     
Impacted Files Coverage Δ
...ar/text-track-controls/chapters-track-menu-item.js 80.00% <ø> (+18.09%) ⬆️
...control-bar/text-track-controls/chapters-button.js 89.06% <92.30%> (-1.68%) ⬇️
src/js/tracks/text-track.js 92.94% <0.00%> (+0.64%) ⬆️
...rc/js/control-bar/progress-control/time-tooltip.js 84.61% <0.00%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5af81ca...d58e80f. Read the comment docs.

@misteroneill misteroneill merged commit 58a8bd0 into main Mar 21, 2022
@misteroneill misteroneill deleted the fix-tests branch March 21, 2022 18:20
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants