Tight coupling with controlBar component

[try2beth3b3st]

Description

We have tight coupling in player.js Class Player method resetControlBarUI_(), when using reset() method.
ControlBar component may be not exists or exists on another nesting level..

Steps to reproduce

Use player.reset() method, when in player object there is no controlBar child/component at property "children"

Results

Expected

Reset player instance

Actual

We have error

Error output

Additional Information

versions

videojs

7.17.1

browsers

all

OSes

all

(Sorry for my bad english)

[welcome]

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

[gkatsev]

Having a control bar is definitely the default use-case. We probably don't test enough with trying to disable default components.
Looks like it's because it's trying to dereference from an undefined object. The solution is likely to add a default value on the line where durationDisplay and remainingTimeDisplay are being destructured.

const  { durationDisplay, remainingTimeDisplay } = this.controlBar ?? {};

if our build doesn't like ?? we can continue using ||.

Are you interesting in submitting a PR?

[try2beth3b3st]

Having a control bar is definitely the default use-case. We probably don't test enough with trying to disable default components. Looks like it's because it's trying to dereference from an undefined object. The solution is likely to add a default value on the line where durationDisplay and remainingTimeDisplay are being destructured.

const  { durationDisplay, remainingTimeDisplay } = this.controlBar ?? {};

if our build doesn't like ?? we can continue using ||.

Are you interesting in submitting a PR?

Yes. But i can't push fix for PR now (Haven't permissions for push).

[mister-ben]

You'll need to create your own fork of the repo, make your changes in a branch, then a pull request to propose the changes from your branch are added to Video.js. There's a quick walkthrough here: https://opensource.com/article/19/7/create-pull-request-github

[try2beth3b3st]

Done