Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(accessibility): frame must have a title attribute #7754

Merged
merged 2 commits into from
May 18, 2022

Conversation

gjanblaszczyk
Copy link
Member

Description

According to some HTML validators, the resize manager frame doesn't pass validation because the title attribute is not present.
Please check the below validators for details

  1. https://rocketvalidator.com/accessibility-validation/frame-title-unique
  2. https://equalizedigital.com/accessibility-checker/iframe-missing-title/

Specific Changes proposed

Add 'title' attribute.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #7754 (5afc7a1) into main (7e2b9ec) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #7754   +/-   ##
=======================================
  Coverage   80.91%   80.91%           
=======================================
  Files         116      116           
  Lines        7457     7457           
  Branches     1807     1807           
=======================================
  Hits         6034     6034           
  Misses       1423     1423           
Impacted Files Coverage Δ
src/js/resize-manager.js 77.08% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e2b9ec...5afc7a1. Read the comment docs.

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validators are weird. Though, definitely no harm in having the title.

@mister-ben
Copy link
Contributor

If it matters for accessibility it should probably be localised...

@gkatsev
Copy link
Member

gkatsev commented May 10, 2022

Given that the iframe should only be used on IE/older browsers (https://caniuse.com/resizeobserver), I'm not sure it's quite as necessary nowadays

@gjanblaszczyk
Copy link
Member Author

@gkatsev Please, feel free to close this PR if you decide it is not needed nowadays.

Btw maybe it is a good time to remove a & Flash video player text from an About text. Rest in peace Flash player... I will never forget you :)

image

@misteroneill
Copy link
Member

Good call! Updated the "About" section to remove the mention of Flash

@misteroneill misteroneill added confirmed patch This PR can be added to a patch release. labels May 16, 2022
@misteroneill misteroneill merged commit a7f2532 into videojs:main May 18, 2022
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed patch This PR can be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants