-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(accessibility): frame must have a title attribute #7754
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7754 +/- ##
=======================================
Coverage 80.91% 80.91%
=======================================
Files 116 116
Lines 7457 7457
Branches 1807 1807
=======================================
Hits 6034 6034
Misses 1423 1423
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validators are weird. Though, definitely no harm in having the title.
If it matters for accessibility it should probably be localised... |
Given that the iframe should only be used on IE/older browsers (https://caniuse.com/resizeobserver), I'm not sure it's quite as necessary nowadays |
@gkatsev Please, feel free to close this PR if you decide it is not needed nowadays. Btw maybe it is a good time to remove a |
Good call! Updated the "About" section to remove the mention of Flash |
Description
According to some HTML validators, the resize manager frame doesn't pass validation because the title attribute is not present.
Please check the below validators for details
Specific Changes proposed
Add 'title' attribute.
Requirements Checklist