Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: stop running placeholder el test in IE and Safari to prevent errors #7769

Merged
merged 1 commit into from
May 20, 2022

Conversation

misteroneill
Copy link
Member

Description

We realized that tests were failing in IE11 and Safari 9 because some new tests introduced in #7722 seem to use unsupported DocumentFragment features.

Rather than try to fix that, we will simply not run these tests in IE or Safari. In 8.0, we will not support IE at all or older Safaris.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@misteroneill misteroneill marked this pull request as ready for review May 20, 2022 16:56
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #7769 (cce7725) into main (1908422) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #7769      +/-   ##
==========================================
- Coverage   80.94%   80.92%   -0.02%     
==========================================
  Files         116      116              
  Lines        7461     7461              
  Branches     1811     1811              
==========================================
- Hits         6039     6038       -1     
- Misses       1422     1423       +1     
Impacted Files Coverage Δ
...rc/js/control-bar/progress-control/time-tooltip.js 82.05% <0.00%> (-2.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1908422...cce7725. Read the comment docs.

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd want to make sure to re-enable this test for safari in v8

@misteroneill
Copy link
Member Author

Absolutely!

@misteroneill misteroneill merged commit 50ffd57 into main May 20, 2022
@misteroneill misteroneill deleted the test/ie-safari branch May 20, 2022 17:21
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants