Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove internal Map, Set, and WeakMap shams, assume window.performance and requestAnimationFrame support #7775

Merged
merged 3 commits into from
Jun 2, 2022

Conversation

misteroneill
Copy link
Member

@misteroneill misteroneill commented May 23, 2022

Description

These are some additional updates and cleanup for a major version of Video.js.

Specific Changes proposed

  • Remove internal Map, Set, and WeakMap shams (assume support for these classes)
  • Remove a stray use of options_.Promise that carried over from main during a rebase
  • Assume support for window.performance and window.performance.now()
  • Assume support for requestAnimationFrame
  • Remove remaining uses of extend() and replace with class instead (except for extend() tests)

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
  • Reviewed by Two Core Contributors

@misteroneill misteroneill changed the base branch from main to next May 23, 2022 23:46
@misteroneill misteroneill marked this pull request as ready for review May 23, 2022 23:47
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #7775 (e124304) into next (337a2a0) will increase coverage by 0.54%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             next    #7775      +/-   ##
==========================================
+ Coverage   81.05%   81.59%   +0.54%     
==========================================
  Files         113      110       -3     
  Lines        7441     7358      -83     
  Branches     1802     1777      -25     
==========================================
- Hits         6031     6004      -27     
+ Misses       1410     1354      -56     
Impacted Files Coverage Δ
src/js/component.js 94.11% <ø> (-0.08%) ⬇️
src/js/player.js 88.82% <86.66%> (+0.07%) ⬆️
src/js/tech/html5.js 66.94% <100.00%> (-0.28%) ⬇️
src/js/tracks/text-track.js 92.94% <0.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 337a2a0...e124304. Read the comment docs.

@misteroneill misteroneill changed the title refactor: remove internal Map, Set, and WeakMap shams, assume window.performance support refactor: remove internal Map, Set, and WeakMap shams, assume window.performance and requestAnimationFrame support May 24, 2022
@misteroneill misteroneill merged commit 742be4e into next Jun 2, 2022
@misteroneill misteroneill deleted the rm-deprecations branch June 2, 2022 16:05
misteroneill added a commit that referenced this pull request Nov 23, 2022
…performance and requestAnimationFrame support (#7775)
misteroneill added a commit that referenced this pull request Nov 23, 2022
…performance and requestAnimationFrame support (#7775)
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants