Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: HTML5 tech with audio tag shouldn't use requestVideoFrameCallback #7778

Merged
merged 1 commit into from
May 31, 2022

Conversation

mister-ben
Copy link
Contributor

Description

The check for requestAnimationFrameCallback assumes a video element, which breaks track updates if an audio el is used.

Specific Changes proposed

Additional check in htmlt tech constructor.

Fixes #7772

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #7778 (655ca98) into main (50ffd57) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #7778   +/-   ##
=======================================
  Coverage   80.92%   80.93%           
=======================================
  Files         116      116           
  Lines        7461     7462    +1     
  Branches     1811     1812    +1     
=======================================
+ Hits         6038     6039    +1     
  Misses       1423     1423           
Impacted Files Coverage Δ
src/js/tech/html5.js 67.29% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50ffd57...655ca98. Read the comment docs.

@misteroneill misteroneill added the patch This PR can be added to a patch release. label May 25, 2022
@misteroneill misteroneill merged commit a14ace2 into videojs:main May 31, 2022
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch This PR can be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

this.el_.requestVideoFrameCallback is not a function
3 participants