Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lang): Add Bengali (bn) translations #7823

Merged
merged 3 commits into from
Sep 15, 2022
Merged

Conversation

themaruf
Copy link
Contributor

Description

Add completed translations for Bengali language.

Specific Changes proposed

New file of Bengali (bn.json) language strings.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@welcome
Copy link

welcome bot commented Jun 30, 2022

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

lang/bn.json Outdated Show resolved Hide resolved
lang/bn.json Outdated Show resolved Hide resolved
Copy link
Contributor

@mister-ben mister-ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments about the replacement tokens, otherise looks good.

Co-authored-by: mister-ben <git@misterben.me>
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #7823 (16a6122) into main (b22a08a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #7823   +/-   ##
=======================================
  Coverage   80.93%   80.93%           
=======================================
  Files         116      116           
  Lines        7463     7463           
  Branches     1813     1813           
=======================================
  Hits         6040     6040           
  Misses       1423     1423           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b22a08a...16a6122. Read the comment docs.

Co-authored-by: mister-ben <git@misterben.me>
Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the PR!

@gkatsev gkatsev merged commit 12b9e8d into videojs:main Sep 15, 2022
@welcome
Copy link

welcome bot commented Sep 15, 2022

Congrats on merging your first pull request! 🎉🎉🎉

edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants