chore(lock-threads): run only daily at 1:00 am, and skip in forks #7832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #7832 +/- ##
=======================================
Coverage 80.93% 80.93%
=======================================
Files 116 116
Lines 7463 7463
Branches 1813 1813
=======================================
Hits 6040 6040
Misses 1423 1423 Continue to review full report at Codecov.
|
|
Thanks, this doesn't need to run often now the backlog is cleared. Could have |
|
I wish actions didn't run in forked repos by default. Can definitely be annoying. |
mister-ben
reviewed
Jul 8, 2022
| @@ -13,6 +13,7 @@ concurrency: | |||
|
|
|||
| jobs: | |||
| action: | |||
| if: ${{ github.repository_owner == 'videojs' }} | |||
There was a problem hiding this comment.
This will cause the jobs to be skipped on forks. They'll still show in the actions list.
There was a problem hiding this comment.
@mister-ben thank you, that's even better !
mister-ben
approved these changes
Jul 11, 2022
gjanblaszczyk
approved these changes
Jul 11, 2022
mister-ben
changed the title
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
…deojs#7832) * chore(lock-action): performed daily at 1:00 am * Skip for forks Co-authored-by: mister-ben <git@misterben.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The github action introduced by #7777 in charge of locking old issues runs every hour and is followed by an e-mail.
Specific Changes proposed
The Lock Threads does not seem to allow restricting its execution to a named repo. The proposal would be to execute the action only once a day to avoid spamming those who have a fork of the project.
Requirements Checklist