Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lang): fixes key spacing within fr.json file #7848

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

tgwittman
Copy link
Contributor

@tgwittman tgwittman commented Jul 18, 2022

Description

When implementing video.js's option language for fr, we noticed that "Picture-in-Picture" wasn't being translated properly. We noticed #7589 introduced this issue within the fr.json file.

Specific Changes proposed

Please refer to issue #7847

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@welcome
Copy link

welcome bot commented Jul 18, 2022

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you!

@tgwittman
Copy link
Contributor Author

tgwittman commented Jul 25, 2022

@misteroneill, @gkatsev, can we get this merged and release a patch?

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #7848 (33f61e4) into main (1be46d4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #7848   +/-   ##
=======================================
  Coverage   80.93%   80.93%           
=======================================
  Files         116      116           
  Lines        7463     7463           
  Branches     1813     1813           
=======================================
  Hits         6040     6040           
  Misses       1423     1423           

Help us with your feedback. Take ten seconds to tell us how you rate us.

@mister-ben mister-ben added the patch This PR can be added to a patch release. label Jul 28, 2022
@gkatsev gkatsev merged commit ebe9f32 into videojs:main Jul 28, 2022
@welcome
Copy link

welcome bot commented Jul 28, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@tgwittman tgwittman deleted the fix-fr-json-spacing branch July 28, 2022 18:14
@tgwittman
Copy link
Contributor Author

@gkatsev, how do we release a patch?

@gkatsev
Copy link
Member

gkatsev commented Jul 28, 2022

Just released 7.20.2 as a next tag on npm.

misteroneill pushed a commit that referenced this pull request Nov 22, 2022
Co-authored-by: Timothy Wittman <timothywittman@adt.com>
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Co-authored-by: Timothy Wittman <timothywittman@adt.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch This PR can be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants