Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove fallback for Element.closest() #7853

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

mister-ben
Copy link
Contributor

Description

Removes the fallback for Element.closest() which was only needed for IE.

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #7853 (a1a2872) into next (4cdb2ab) will increase coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             next    #7853      +/-   ##
==========================================
+ Coverage   81.60%   81.81%   +0.20%     
==========================================
  Files         110      111       +1     
  Lines        7350     7373      +23     
  Branches     1777     1777              
==========================================
+ Hits         5998     6032      +34     
+ Misses       1352     1341      -11     
Impacted Files Coverage Δ
src/js/player.js 89.45% <100.00%> (+0.63%) ⬆️
src/js/title-bar.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@misteroneill misteroneill merged commit 46c8688 into videojs:next Aug 2, 2022
misteroneill pushed a commit that referenced this pull request Nov 23, 2022
misteroneill pushed a commit that referenced this pull request Nov 23, 2022
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants