feat: make retryOnError be the default #7868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that a retryOnError is removed and is no longer needed for this behavior, which means that during source selection, if a source fails, it'll try the next source that's available, to match the video element. BREAKING CHANGE: remove retryOnError option, turn it on by default
24 tasks
Codecov Report
@@ Coverage Diff @@
## next #7868 +/- ##
==========================================
+ Coverage 81.90% 81.91% +0.01%
==========================================
Files 111 111
Lines 7344 7344
Branches 1771 1771
==========================================
+ Hits 6015 6016 +1
+ Misses 1329 1328 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
misteroneill
approved these changes
Aug 8, 2022
misteroneill
pushed a commit
that referenced
this pull request
Nov 23, 2022
This means that a retryOnError is removed and is no longer needed for this behavior, which means that during source selection, if a source fails, it'll try the next source that's available, to match the video element. BREAKING CHANGE: remove retryOnError option, turn it on by default
misteroneill
pushed a commit
that referenced
this pull request
Nov 23, 2022
This means that a retryOnError is removed and is no longer needed for this behavior, which means that during source selection, if a source fails, it'll try the next source that's available, to match the video element. BREAKING CHANGE: remove retryOnError option, turn it on by default
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
This means that a retryOnError is removed and is no longer needed for this behavior, which means that during source selection, if a source fails, it'll try the next source that's available, to match the video element. BREAKING CHANGE: remove retryOnError option, turn it on by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that a retryOnError is removed and is no longer needed for
this behavior, which means that during source selection, if a source
fails, it'll try the next source that's available, to match the video
element.
BREAKING CHANGE: remove retryOnError option, turn it on by default