refactor: rename fn.bind to fn.bind_ to strongly indicate it should not be used externally #7940
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
utils/fn.bind
function will be exposed in Video.js 8 becausefn
is exposed asvideojs.fn
. We don't want people using it, but it cannot be removed without breaking the Video.js event system.This PR adds a
_
at the end of its name to indicate that it is private.No external updates should be needed as it was not directly exposed. The previously-supported
videojs.bind
has been deprecated.Specific Changes proposed
utils/fn.bind
toutils/fn.bind_
Requirements Checklist