Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8] Empty src attribute of the img element when no poster is added #8122

Closed
boris-petrov opened this issue Feb 10, 2023 · 0 comments · Fixed by #8130
Closed

[v8] Empty src attribute of the img element when no poster is added #8122

boris-petrov opened this issue Feb 10, 2023 · 0 comments · Fixed by #8130
Labels
bug

Comments

@boris-petrov
Copy link
Contributor

Description

The poster is set to an empty string if no poster is initially configured. Which causes that empty string to be set for src of the img element of the poster. Which is invalid HTML according to HTML-validators.

Reduced test case

No response

Steps to reproduce

Check the description for an explanation.

Errors

No response

What version of Video.js are you using?

8.0.4

Video.js plugins used.

No response

What browser(s) including version(s) does this occur with?

110

What OS(es) and version(s) does this occur with?

Linux
@boris-petrov boris-petrov added bug needs: triage This issue needs to be reviewed labels Feb 10, 2023
@mister-ben mister-ben mentioned this issue Feb 13, 2023
Merged
7 tasks
@mister-ben mister-ben removed the needs: triage This issue needs to be reviewed label Feb 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove img el when there's no poster source mister-ben/video.js
2 participants
@boris-petrov @mister-ben