Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation about alt distributions #8179

Open
Makio64 opened this issue Mar 8, 2023 · 6 comments
Open

Improve documentation about alt distributions #8179

Makio64 opened this issue Mar 8, 2023 · 6 comments
Labels
documentation needs: triage This issue needs to be reviewed

Comments

@Makio64
Copy link
Contributor

Makio64 commented Mar 8, 2023

Description

Hello,

I was looking into the distributions made by videojs but in the documentation there is not explaination about whats include/not include in the core version.

Would be also nice to have a short explaination similar to the one for novtt versions.
Also would be nice to put the approximate kb of each versions. ( as there is more than 400kb diff between the video.core.min.js and the videojs.min.js )

Documentation link :
https://videojs.com/getting-started/#distributions

Thanks !

Reduced test case

https://videojs.com/getting-started/#distributions

Steps to reproduce

Read the documentations.

Errors

No response

What version of Video.js are you using?

8.0.4

Video.js plugins used.

none

What browser(s) including version(s) does this occur with?

All

What OS(es) and version(s) does this occur with?

All

@Makio64 Makio64 added bug needs: triage This issue needs to be reviewed labels Mar 8, 2023
@welcome
Copy link

welcome bot commented Mar 8, 2023

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@ravixalgorithm
Copy link

ravixalgorithm commented Jul 11, 2024

Can I contribute to it? @mister-ben @Makio64

@mister-ben
Copy link
Contributor

Contributions are very welcome! The guides are in the videos/videos.com repo.

@ravixalgorithm
Copy link

@mister-ben where can I find this page to edit it, is it located in videojs.com repo?

@amtins
Copy link
Contributor

amtins commented Jul 12, 2024

@ravixalgorithm you'll find the page here: https://github.com/videojs/videojs.com/blob/main/src/mdx-pages/getting-started.mdx

@ravixalgorithm
Copy link

@mister-ben I made the changes in pull request #193, Please review all the changes and merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation needs: triage This issue needs to be reviewed
Projects
None yet
Development

No branches or pull requests

4 participants