Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lang): improve Italian labels #8193

Merged
merged 2 commits into from
Mar 21, 2023
Merged

fix(lang): improve Italian labels #8193

merged 2 commits into from
Mar 21, 2023

Conversation

astagi
Copy link
Contributor

@astagi astagi commented Mar 15, 2023

Description

This PR improves Italian labels using a more friendly and direct language

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@welcome
Copy link

welcome bot commented Mar 15, 2023

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@mister-ben mister-ben changed the title chore(i18n): improve Italian labels fix(lang): improve Italian labels Mar 15, 2023
@codecov
Copy link

codecov bot commented Mar 15, 2023 •
edited
Loading

Codecov Report

Merging #8193 (741ebe5) into main (35c539d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8193   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files         112      112           
  Lines        7402     7402           
  Branches     1785     1785           
=======================================
  Hits         6078     6078           
  Misses       1324     1324

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

mister-ben
mister-ben approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@mister-ben mister-ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie!

lang/it.json Outdated
@@ -71,14 +71,14 @@
"Proportional Serif": "Carattere a spaziatura variabile con grazie (Proportional Serif)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to your changes, but noting while I'm here that these are way too long for the captions settings box where they're displayed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, these look to be literal translations :) I'll fix them in another commit using "Serif proporzionale" and "Serif monospazio" labels

mister-ben
mister-ben requested changes Mar 16, 2023
View reviewed changes
lang/it.json Outdated
"Monospace Sans-Serif": "Carattere a spaziatura fissa senza grazie (Monospace Sans-Serif)",
"Proportional Serif": "Carattere a spaziatura variabile con grazie (Proportional Serif)",
"Monospace Serif": "Carattere a spaziatura fissa con grazie (Monospace Serif)",
"Proportional Sans-Serif": Sans-Serif proporzionale",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Proportional Sans-Serif": Sans-Serif proporzionale",
"Proportional Sans-Serif": "Sans-Serif proporzionale",

missing a quote here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! sorry, I'll amend my last commit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done @mister-ben

@misteroneill misteroneill merged commit fefd525 into videojs:main Mar 21, 2023
@welcome
Copy link

welcome bot commented Mar 21, 2023

Congrats on merging your first pull request! 🎉🎉🎉

edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
@astagi @edirub
fix(lang): improve Italian labels (videojs#8193)
3754404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misteroneill misteroneill misteroneill approved these changes

@mister-ben mister-ben mister-ben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@astagi @misteroneill @mister-ben