Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update CI and release workflows #8214

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

philjhale
Copy link
Contributor

@philjhale philjhale commented Mar 28, 2023

Description

  • Update deprecated set-output command. This will stop working in June 2023. See this post.
  • Update actions to use Node 16 rather than Node 12. Github are currently migrating away from Node 12. See this post.
  • GabrielBB/xvfb-action is no longer maintained and there is no Node 16 version. Therefore it was replaced with coactions/setup-xvfb.

I've also opened a PR to update the workflow templates #8214

* Update deprecated set-output command.
* Update actions to use Node 16 rather than Node 12.
@welcome
Copy link

welcome bot commented Mar 28, 2023

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #8214 (b25e06f) into main (c1a1f9c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8214   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files         112      112           
  Lines        7402     7402           
  Branches     1785     1785           
=======================================
  Hits         6078     6078           
  Misses       1324     1324           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philjhale philjhale merged commit 882f3af into videojs:main Mar 30, 2023
@welcome
Copy link

welcome bot commented Mar 30, 2023

Congrats on merging your first pull request! 🎉🎉🎉

@philjhale philjhale deleted the update-workflows-2 branch March 30, 2023 14:22
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
* Update deprecated set-output command.
* Update actions to use Node 16 rather than Node 12.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants