Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: audio description track doesn't have icon on Safari browser #8232

Merged

Conversation

gjanblaszczyk
Copy link
Member

On Firefox/Chrome browser the HLS stream that contains an audio track with a description show AD icon in the menu list.
image
However, The same stream on Safari doesn't have the AD icon.

Description

Safari without VHS (in native mode) creates an audio track with a kind attribute value equal to "description".
Unfortunately, video.js handles track kind attribute value equal to "main-desc" only.

Specific Changes proposed

Add support for kind: "description"

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #8232 (de1cc2d) into main (d26780e) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #8232   +/-   ##
=======================================
  Coverage   82.31%   82.31%           
=======================================
  Files         112      112           
  Lines        7452     7452           
  Branches     1796     1796           
=======================================
  Hits         6134     6134           
  Misses       1318     1318           
Impacted Files Coverage Δ
...-bar/audio-track-controls/audio-track-menu-item.js 3.03% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@mister-ben mister-ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the mixed content in the legacy docs is flagged for this PR in particular, but it's unrelated to the change.

@misteroneill misteroneill merged commit 52bad2b into videojs:main May 31, 2023
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants