Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix text track settings responsiveness when default font size is modified #8294

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

amtins
Copy link
Contributor

@amtins amtins commented May 29, 2023

Description

This PR fixes the responsiveness of the text track settings when the default font size of .video-js is modified and only the label size was updated.

text-track-settings.webm

Specific Changes proposed

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #8294 (ef6633d) into main (f1558c6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8294   +/-   ##
=======================================
  Coverage   82.36%   82.36%           
=======================================
  Files         112      112           
  Lines        7483     7483           
  Branches     1804     1804           
=======================================
  Hits         6163     6163           
  Misses       1320     1320           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@misteroneill misteroneill added the needs: LGTM Needs one or more additional approvals label Jun 2, 2023
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some things shifted around because the font sizes differ a tiny bit, but it's not worth keeping things pixel identical.

LGTM.

@misteroneill misteroneill changed the title Fix text track settings responsiveness fix: fix text track settings responsiveness when default font size is modified Jun 6, 2023
@misteroneill misteroneill added confirmed and removed needs: LGTM Needs one or more additional approvals labels Jun 6, 2023
@misteroneill misteroneill merged commit 3dece50 into videojs:main Jun 6, 2023
@amtins amtins deleted the fix/text-track-settings branch November 5, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants