Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(progress): mouse-time-display overlaps the play-progress svg icon #8338

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

amtins
Copy link
Contributor

@amtins amtins commented Jul 2, 2023

Description

This PR fixes when the mouse hovers over the play-progress svg icon, the mouse-time-display bar appears above it.

Screencast.from.02.07.23.20.16.42.webm

Specific Changes proposed

  • adds z-index to avoid overlap

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

When the mouse hovers over the `play-progress` svg icon,
the `mouse-time-display` bar appears above it.

- adds `z-index` to avoid overlap
@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Merging #8338 (0b1c8eb) into main (2b0df25) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8338   +/-   ##
=======================================
  Coverage   82.68%   82.68%           
=======================================
  Files         113      113           
  Lines        7561     7561           
  Branches     1818     1818           
=======================================
  Hits         6252     6252           
  Misses       1309     1309           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mister-ben mister-ben merged commit e06465f into videojs:main Jul 4, 2023
@amtins amtins deleted the fix/play-progress-svg-icon-z-index branch November 5, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants