Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(error-display): avoids displaying visual components when an error occurs #8389

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

amtins
Copy link
Contributor

@amtins amtins commented Aug 5, 2023

Description

When an error occurs, only the error screen should be displayed to maintain visual consistency.

Screenshot from 2023-08-05 15-11-22

Specific Changes proposed

  • Hides the Title Bar
  • Hides the Loading Spinner
  • Hides the Captions Settings
  • Hides the Text Track Display

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

… occurs

When an error occurs, only the error screen should be displayed to maintain visual consistency.

- Hides the Title Bar
- Hides the Loading Spinner
- Hides the Captions Settings
- Hides the Text Track Display
@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #8389 (955a176) into main (3e9ef0a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8389   +/-   ##
=======================================
  Coverage   82.68%   82.68%           
=======================================
  Files         113      113           
  Lines        7578     7578           
  Branches     1821     1821           
=======================================
  Hits         6266     6266           
  Misses       1312     1312           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mister-ben mister-ben merged commit 42e17b2 into videojs:main Aug 17, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants