Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lang): Add support for Marathi Language #8596

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

rajsfk7
Copy link
Contributor

@rajsfk7 rajsfk7 commented Feb 16, 2024

Support for indian lanuage marathi is added for multilingual support

Description

Support for indian lanuage marathi is added for multilingual support

Specific Changes proposed

Translation Text for Marathi Language Added

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

Support for indian lanuage marathi is added for multilingual support
Copy link

welcome bot commented Feb 16, 2024

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link
Contributor

@mister-ben mister-ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've left a couple of inline comments.

lang/mr.json Outdated Show resolved Hide resolved
lang/mr.json Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.71%. Comparing base (395d608) to head (07f7089).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8596   +/-   ##
=======================================
  Coverage   82.71%   82.71%           
=======================================
  Files         113      113           
  Lines        7636     7636           
  Branches     1835     1835           
=======================================
  Hits         6316     6316           
  Misses       1320     1320           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mister-ben mister-ben changed the title Support for Marathi Language added feat(lang): Add support for Marathi Language Mar 4, 2024
@mister-ben mister-ben added the needs: LGTM Needs one or more additional approvals label Mar 4, 2024
lang/mr.json Show resolved Hide resolved
Copy link
Contributor

@adrums86 adrums86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mister-ben mister-ben merged commit 80429fa into videojs:main Apr 12, 2024
12 checks passed
Copy link

welcome bot commented Apr 12, 2024

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: LGTM Needs one or more additional approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants