Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update GitHub Actions version and remove xvfb #8682

Merged
merged 5 commits into from
Apr 12, 2024

Conversation

mister-ben
Copy link
Contributor

@mister-ben mister-ben commented Apr 11, 2024

Updates actions to address GitHub's Node 16 deprecation.

Updating codecov to v4 hopefully improves the reliability uploading. This change means contributors wanting codecov in their forks need to add a CODECOV_TOKEN secret to their repository with their codecov token.

Removes the xvfb action as avfb is available by default on ubuntu in GitHub Actions.

@mister-ben mister-ben marked this pull request as draft April 11, 2024 19:54
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.49%. Comparing base (8e5870f) to head (991ce58).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8682      +/-   ##
==========================================
+ Coverage   82.85%   83.49%   +0.64%     
==========================================
  Files         113      113              
  Lines        7647     7647              
  Branches     1839     1839              
==========================================
+ Hits         6336     6385      +49     
+ Misses       1311     1262      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mister-ben mister-ben changed the title DRAFT chore: update codecov chore: update GitHub Actions version and remove xvfb Apr 12, 2024
@mister-ben mister-ben marked this pull request as ready for review April 12, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants