Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tap to click not work not progressbar #8691

Closed
maytinhdibo opened this issue Apr 17, 2024 · 5 comments · Fixed by #8700
Closed

Tap to click not work not progressbar #8691

maytinhdibo opened this issue Apr 17, 2024 · 5 comments · Fixed by #8700

Comments

@maytinhdibo
Copy link

Description

On macOS, when playing video, can not light click (tap) to change progress bar

Reduced test case

https://videojs.com/advanced/?video=disneys-oceans

Steps to reproduce

  1. Play a video
  2. Light click (tap) on progress bar

Errors

No response

What version of Video.js are you using?

newest

Video.js plugins used.

No response

What browser(s) including version(s) does this occur with?

Chrome, Firefox

What OS(es) and version(s) does this occur with?

macOS

@maytinhdibo maytinhdibo added the needs: triage This issue needs to be reviewed label Apr 17, 2024
Copy link

welcome bot commented Apr 17, 2024

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@mister-ben
Copy link
Contributor

Do you mean when using "Tap to click" enable in MacOS's trackpad settings?

@maytinhdibo
Copy link
Author

Do you mean when using "Tap to click" enable in MacOS's trackpad settings?

Yes, it's enabled on macOS setting, but must strong click (force touch) to click progress bar.

@mister-ben
Copy link
Contributor

mister-ben commented Apr 18, 2024

A "tap to click" reaches here and considered not a single left click because event.buttons is 0 on mousedown on Sonoma. On Ventura it'a usually 1 but sometimes also 0.

@maytinhdibo
Copy link
Author

A "tap to click" reaches here and considered not a single left click because event.buttons is 0 on mousedown on Sonoma. On Ventura it'a usually 1 but sometimes also 0.

I think we have to change it to click event. Default video tag handle this event. This issue is only on video.js. Sync with native behaviour.

@mister-ben mister-ben added confirmed and removed needs: triage This issue needs to be reviewed labels Apr 19, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants