Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove plugin errors from error const #8706

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

wseymour15
Copy link
Contributor

Description

Removes error consts that are outside of the video.js repo. These error consts are being added directly to the contrib-ads and contrib-eme repos.

Specific Changes proposed

  • Remove error consts that are used in video.js plugins.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.65%. Comparing base (c2c7f96) to head (f325e16).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8706      +/-   ##
==========================================
- Coverage   83.69%   83.65%   -0.04%     
==========================================
  Files         120      120              
  Lines        7996     7996              
  Branches     1926     1926              
==========================================
- Hits         6692     6689       -3     
- Misses       1304     1307       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wseymour15 wseymour15 merged commit 466fa97 into main Apr 23, 2024
13 of 14 checks passed
@wseymour15 wseymour15 deleted the chore/remove-from-error-const branch April 23, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants