Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove safe-json-parse #8790

Merged
merged 3 commits into from
Aug 11, 2024

Conversation

mister-ben
Copy link
Contributor

Description

Removes an old unmaintained dependency that isn't needed any more.

Specific Changes proposed

Replace safe-json-parse with JSON.parse

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.08%. Comparing base (970faa8) to head (6e4dd73).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8790      +/-   ##
==========================================
+ Coverage   83.07%   83.08%   +0.01%     
==========================================
  Files         120      120              
  Lines        8022     8021       -1     
  Branches     1925     1924       -1     
==========================================
  Hits         6664     6664              
+ Misses       1358     1357       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ravixalgorithm

This comment was marked as off-topic.

@mister-ben mister-ben added the needs: LGTM Needs one or more additional approvals label Jul 12, 2024
@mister-ben mister-ben added patch This PR can be added to a patch release. and removed needs: LGTM Needs one or more additional approvals labels Aug 11, 2024
@mister-ben mister-ben merged commit 3380d33 into videojs:main Aug 11, 2024
11 checks passed
@mister-ben mister-ben deleted the chore-remove-safe-json-parse branch August 12, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch This PR can be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants