fix: Change requestNamedAnimationFrame to apply last change per frame instead of first #8799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8799 +/- ##
=======================================
Coverage 83.12% 83.12%
=======================================
Files 120 120
Lines 8052 8052
Branches 1931 1931
=======================================
Hits 6693 6693
Misses 1359 1359 ☔ View full report in Codecov by Sentry. |
mister-ben
changed the title
| @@ -1714,7 +1714,7 @@ class Component { | |||
| */ | |||
| requestNamedAnimationFrame(name, fn) { | |||
| if (this.namedRafs_.has(name)) { | |||
| return; | |||
| this.cancelNamedAnimationFrame(name); | |||
There was a problem hiding this comment.
Should this still return as well or do we now want to execute the code below?
There was a problem hiding this comment.
Previous, if a raf with that name is already queued, it returned and did not add the new raf of this name.
Now if the named raf is queued, instead of returning, that queued one is cancelled, then the new raf is added.
misteroneill
approved these changes
Aug 12, 2024
mister-ben
removed
needs: discussion
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation of
requestNamedAnimationFrameprevents multiple updates on a frame but by disregarding all but the first request per frame. This throttling behaviour is apparent when playing a very short video - if atimeupdateoccurs just before theendedevent, the progress bar position on thetimeupdateis set at say 98% and 100% from theendedis discarded. Although #8633 removed the throttle from theendedhandler itself, the throttle and non-throttled update can still both execute between frames.Specific Changes proposed
Changes the implementation to apply only the last callback instead. If any exist they will be cancelled. There will still be only one update, but now it's the last.
Updates tests to reflect the changed behaviour.
Fixes #8782
Requirements Checklist
npm run docs:apito error