Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update version number in readme on release #8840

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

mister-ben
Copy link
Contributor

@mister-ben mister-ben commented Aug 23, 2024

Description

Updates the version number where it appears in URLs in the README, when nom version is ran. It's looking specifically for patterns like /8.17.3/ and /video.js@8.17.3/; if we change the README we need to consider this script.

Specific Changes proposed

New script at build/readme-version.js

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.18%. Comparing base (73db132) to head (bbd8f08).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8840   +/-   ##
=======================================
  Coverage   83.18%   83.18%           
=======================================
  Files         120      120           
  Lines        8047     8047           
  Branches     1931     1931           
=======================================
  Hits         6694     6694           
  Misses       1353     1353           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mister-ben mister-ben added the needs: LGTM Needs one or more additional approvals label Aug 23, 2024
@mister-ben mister-ben removed the needs: LGTM Needs one or more additional approvals label Aug 27, 2024
@mister-ben mister-ben merged commit 5fac9e1 into videojs:main Aug 28, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants