Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default video controls are behind video-js' custom controls #9

Closed
rabisuz opened this issue Jun 3, 2010 · 1 comment
Closed

Default video controls are behind video-js' custom controls #9

rabisuz opened this issue Jun 3, 2010 · 1 comment

Comments

@rabisuz
Copy link

rabisuz commented Jun 3, 2010

If the default controls are used, they are not hidden by video-js. This can be prevented by adding one line to video.js.

Patch:
--- a/video.js
+++ b/video.js
@@ -40,6 +40,9 @@ var VideoJS = Class.extend({

     this.buildController();
     this.showController();
+    
+    // Hide default controls
+    this.video.controls = false;

     // Position & show controls when data is loaded
     this.video.addEventListener("loadeddata", this.onLoadedData.context(this), false);
--
@heff
Copy link
Member

heff commented Jun 9, 2010

Good call. Added it in. Thanks!

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants