Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SourceHandler setSource check fails on minified version #1753

Closed
matteos opened this issue Dec 18, 2014 · 2 comments
Closed

SourceHandler setSource check fails on minified version #1753

matteos opened this issue Dec 18, 2014 · 2 comments

Comments

@matteos
Copy link
Contributor

matteos commented Dec 18, 2014

The new check for setSource method fails on minified js, because setSource is not exported.
In player.js :

        if (window['videojs'][this.techName].prototype.hasOwnProperty('setSource')) {
          this.techCall('setSource', source);
        } else {
          this.techCall('src', source.src);
        }

The new method will never be called when using the minified version.
I've tried adding the property to exports.js and it does resolve the issue.

@heff
Copy link
Member

heff commented Dec 18, 2014

Oh man...GCC strikes again. Thanks for figuring this out. Want to submit a pull request for the updates?

@heff
Copy link
Member

heff commented Dec 19, 2014

This has been fixed by #1754 and released in v4.11.3. e2c5462

@heff heff closed this as completed Dec 19, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants